Commit Graph

416 Commits

Author SHA1 Message Date
Francois Best 7bb96f9780 feat: Export type definitions when using macros
Types have names prepended by the port name
(defaults to `MIDI`), to allow multi-port applications.

This allows referencing those types elsewhere in the
application, without re-writing the template arguments,
and simplifies referencing the underlying Message type,
for SoftThru `filter`/`map`function definitions.

Proposition & discussion:
https://github.com/FortySevenEffects/arduino_midi_library/pull/232#issuecomment-910355200
2021-09-02 22:49:14 +02:00
Francois Best 2fec41ecfe chore: Add example 2021-08-31 15:23:54 +02:00
Eric Sherman 6bdb70727f
uses Transport::thruActivated for initial thru state 2021-08-06 10:41:05 -04:00
Francois Best 2ae9d9e509
chore: Allow copying Messages
This is ground work for the `map` Thru function
in PR #232.
2021-08-06 03:48:24 -04:00
Eric Sherman 08f6f53d12
makes changes requested in #232 discussion 2021-08-06 03:11:27 -04:00
Eric Sherman 00206071e6
thru filter overhaul
* resolves #40 with franky47's proposed thru filter overhaul
* removes thru filter modes
* adds thru filter callback
* adds thru map callback
* old thru filter unit tests have been replicated with filter callbacks
* does not yet include documentation changes

I believe this implements the latest proposal for #40 and exercises
everything necessary in the unit tests, including the immutability of
`mMessage` after a thru map callback has modified the outgoing message.

The thru filter callbacks in the unit tests are not suitable for copying
and pasting by end-users due to the difference in the MIDI namespace
when setup via the unit tests vs via `MIDI_CREATE_DEFAULT_INSTANCE()`.

If the changes here are deemed suitable, I'll work on documentation.
2021-08-05 20:38:30 -04:00
lathoub d501f4bb3d end method for Serial Transport
The Transport layer is started, but could never be stopped.
This change will allow the underlying library to call the end() method in the Transport layers (all other Transport layer have the end() method implemented)

Next step is to call the Transport end() method, when ending the MIDI instance
2021-06-08 20:36:38 +02:00
François Best d9149d19df
chore: Better description for Discussions 2020-12-09 14:04:49 +01:00
François Best a93fb27a1c
chore: Add link to Discussions in issue templates 2020-12-09 11:39:42 +01:00
François Best d967c0c389
chore: Disable generic issues
General community-related Q&A is moved to Discussions
2020-12-09 11:34:22 +01:00
François Best d3c361033d
chore: Suggest using Discussions first 2020-12-09 11:28:26 +01:00
François Best 33b294624a chore: Add Feature Request template
Also redirect issues to discussions for project help.
2020-12-09 11:26:09 +01:00
François Best 10ef10bfde feat: Add issue template for bug report 2020-12-09 11:20:27 +01:00
Felix Uhl da8ca5e69a Update search term for library manager 2020-09-16 16:39:29 +02:00
Felix Uhl e292cf61b0 Update library manager screenshot 2020-09-16 16:39:29 +02:00
stfufane 150cecd450 Fix sendPitchBend multiplication 2020-06-08 11:39:16 +02:00
lathoub ff3052ceb4 fix bug in MIDI_CREATE_CUSTOM_INSTANCE
- MIDI Setting in MIDI_CREATE_CUSTOM_INSTANCE, but Setting for SerialMIDI
- MACRO outside of Namespace
2020-05-16 15:51:03 +02:00
Francois Best e5ee620139 doc: Add contributor 2020-04-28 07:34:38 +02:00
Francois Best 0d9f6f4731 chore: Release 5.0.2
Includes fix for missing MIDI_CREATE_CUSTOM_INSTANCE,
see #150.
2020-04-28 07:31:42 +02:00
Rolel 42 80dfb8333c [FIX] Repair missing MIDI_CREATE_CUSTOM_INSTANCE
The MIDI_CREATE_CUSTOM_INSTANCE function was removed with 5.0 branch. This commit brings it back.
2020-04-28 07:28:24 +02:00
Francois Best d0110e4866 doc: Thru is off by default in other transports 2020-04-24 07:10:21 +02:00
Francois Best ce57d26d2c doc: Update example 2020-04-24 07:10:02 +02:00
Francois Best 47ce2acc16 chore: Update version & package metadata 2020-04-24 06:52:25 +02:00
Francois Best 1375b0b6aa doc: Update URL 2020-04-24 06:52:02 +02:00
Francois Best 116dba12eb chore: Update compiler config file 2020-04-24 06:49:55 +02:00
Francois Best aa4912b587 chore: Update version in documentation 2020-04-24 06:47:49 +02:00
Francois Best c0a66516f6
thruActivated as a property of the Transport layer (#148)
* thruActivated as a property of the Transport layer

* thruActivated defaults to true

Co-authored-by: lathoub <lathoub@gmail.com>
2020-04-24 06:44:59 +02:00
lathoub a5e31f15a4
thruActivated defaults to true 2020-04-23 22:14:59 +02:00
lathoub 99a981be5e thruActivated as a property of the Transport layer 2020-04-23 22:08:15 +02:00
Francois Best 419c74adfe doc: Add AppleMIDI & release notes 2020-04-20 17:33:46 +02:00
Francois Best 5e9a0165d9 docs: Contributions 2020-04-20 17:30:03 +02:00
Francois Best d600656f04 Merge branch dev into master 2020-04-20 17:09:02 +02:00
Francois Best 804e59669e
Merge pull request #95 from FortySevenEffects/feat/4.4.0
v5.0.0
2020-04-20 17:02:01 +02:00
Francois Best fc360d60b3 chore: Remove Google test coverage 2020-04-20 16:47:36 +02:00
Francois Best b384278b29 chore: Ignore edge cases for coverage 2020-04-20 15:36:12 +02:00
Francois Best ae49d3037d chore: Ignore external coverage 2020-04-20 15:31:26 +02:00
Francois Best 2d6bdd6dc2 doc: Move Documentation section up 2020-04-20 15:22:41 +02:00
Francois Best c2d17ec429 chore: Update lcov to latest available version 2020-04-20 15:22:18 +02:00
lathoub c1d2f476b8
Update unit-tests_MidiInput.cpp 2020-04-20 14:31:51 +02:00
lathoub 45fb2df88f
listen on channel 1 by default
Listening to all channels by default breaks backward compatibility
2020-04-20 14:17:43 +02:00
lathoub 05487c5415
Example not relevant for Due and ZERO as they lack support for SoftwareSerial 2020-04-20 14:11:58 +02:00
lathoub e06e3677f0
bug fix: HardwareSerial => SoftwareSerial 2020-04-20 13:09:39 +02:00
lathoub c5330945ee
Delete altPinSerialMIDI.h 2020-04-20 13:09:01 +02:00
lathoub 1e14162bf4
rewrote AltPinSerial to use SoftwareSerial 2020-04-20 13:08:49 +02:00
lathoub 9d43a8370e
added AltPinSerial example 2020-04-19 21:37:39 +02:00
lathoub b457f6db7c added USB Migration and other Transport mechanisms 2020-04-17 22:09:06 +02:00
lathoub be85c7b3e0 SerialUSB is of type Serial_, not HardwareSerial 2020-04-17 22:05:49 +02:00
Francois Best 23c53cafe1 fix: Remove USB-based Teensys from CI 2020-04-17 08:41:16 +02:00
Francois Best f8707ed49a chore: Add all Teensy boards to CI 2020-04-17 08:22:05 +02:00
Francois Best a9664ef4a4 fix: Use SysEx size in Settings 2020-04-17 08:15:42 +02:00