Seich
/
HomeSpan
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Saving 10 bytes twice 

HAP config number can't be higher than 65535, which fits into 6 bytes
rather than 16, including null.
This commit is contained in:
Francois 2023-11-15 20:29:04 -05:00
parent 4ab7503a72
commit d4df7903cd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/HomeSpan.cpp
View File

@ -482,7 +482,7 @@ void Span::checkConnect(){
// add MDNS (Bonjour) TXT records for configurable as well as fixed values (HAP Table 6-7)
char cNum[16];
char cNum[6];
sprintf(cNum,"%d",hapConfig.configNumber);
mdns_service_txt_item_set("_hap","_tcp","c#",cNum); // Accessory Current Configuration Number (updated whenever config of HAP Accessory Attribute Database is updated)
@ -1600,7 +1600,7 @@ boolean Span::updateDatabase(boolean updateMDNS){
if(memcmp(tHash,hapConfig.hashCode,48)){ // if hash code of current HAP database does not match stored hash code
memcpy(hapConfig.hashCode,tHash,48); // update stored hash code
hapConfig.configNumber++; // increment configuration number
if(hapConfig.configNumber==65536) // reached max value
if(hapConfig.configNumber==65536) // reached max value. Update cNum everywhere if this number is ever increased
hapConfig.configNumber=1; // reset to 1
nvs_set_blob(HAPClient::hapNVS,"HAPHASH",&hapConfig,sizeof(hapConfig)); // update data
@ -1608,7 +1608,7 @@ boolean Span::updateDatabase(boolean updateMDNS){
changed=true;
if(updateMDNS){
char cNum[16];
char cNum[6];
sprintf(cNum,"%d",hapConfig.configNumber);
mdns_service_txt_item_set("_hap","_tcp","c#",cNum);
}