Bump js-yaml from 3.14.0 to 4.0.0 (#186)

* Bump js-yaml from 3.14.0 to 4.0.0

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.0 to 4.0.0.
- [Release notes](https://github.com/nodeca/js-yaml/releases)
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodeca/js-yaml/compare/3.14.0...4.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updating js-yaml to 4.0

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: David Diaz <seich@martianwabbit.com>

LICENSE

@@ -1,7 +1,41 @@
-Copyright 2018 David Sergio Díaz
+“Commons Clause” License Condition v1.0
 
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+The Software is provided to you by the Licensor under the License, as defined
+below, subject to the following condition.
 
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+Without limiting other conditions in the License, the grant of rights under the
+License will not include, and the License does not grant to you, the right to
+Sell the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+For purposes of the foregoing, “Sell” means practicing any or all of the rights
+granted to you under the License to provide to third parties, for a fee or other
+consideration (including without limitation fees for hosting or consulting/
+support services related to the Software), a product or service whose value
+derives, entirely or substantially, from the functionality of the Software. Any
+license notice or attribution required by the License must also include this
+Commons Clause License Condition notice.
+
+Software: Beau
+License: MIT
+Licensor: David Díaz
+
+---
+
+Copyright 2020 David Díaz
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+the Software, and to permit persons to whom the Software is furnished to do so,
+subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

bin/cli/base.js

@@ -18,7 +18,7 @@ class Base extends Command {
         }
 
         let config
-        yaml.safeLoadAll(fs.readFileSync(configFile, 'utf-8'), (doc) => {
+        yaml.loadAll(fs.readFileSync(configFile, 'utf-8'), (doc) => {
             const valid = validate(doc)
 
             if (!valid) {

bin/cli/commands/list.js

@@ -1,5 +1,6 @@
 const clc = require('cli-color')
 const { Line } = require('clui')
+const { expandPath } = require('../../../src/shared')
 const Base = require('../base')
 
 class ListCommand extends Base {
@@ -31,9 +32,7 @@ class ListCommand extends Base {
                 .padding(2)
                 .column(VERB, 20, [clc.yellow])
                 .column(ALIAS, 30, [clc.yellow])
-                .column(
-                    ENDPOINT.replace(/\/$/, '') + '/' + PATH.replace(/^\//, '')
-                )
+                .column(expandPath(ENDPOINT, PATH))
                 .output()
         )
 

bin/cli/commands/request.js

@@ -4,6 +4,7 @@ const clc = require('cli-color')
 const prompts = require('prompts')
 const { Line, Spinner } = require('clui')
 const { flags } = require('@oclif/command')
+const { expandPath } = require('../../../src/shared')
 
 class RequestCommand extends Base {
     prettyOutput(res, verbose = false) {
@@ -69,13 +70,13 @@ class RequestCommand extends Base {
                 ({ VERB, ALIAS, ENDPOINT, PATH }) => ({
                     title: `${VERB} ${PATH} - ${ALIAS}`,
                     value: ALIAS,
-                    description: `${ENDPOINT}${PATH}`
+                    description: expandPath(ENDPOINT, PATH)
                 })
             )
 
             const { name } = await prompts({
                 name: 'name',
-                message: 'Pick as Request to execute',
+                message: 'Pick a Request to execute',
                 type: 'select',
                 choices: requests
             })

examples/beau.yml

@@ -1,19 +1,37 @@
-endpoint: https://pokeapi.co/api/v2
+endpoint: https://pokeapi.co/api/v2/
 
 # Try replacing this pokemon using params:
 # beau request get-pokemon -P "pokemon=dragapult"
 environment:
-  _:
-    pokemon: ditto
+    _:
+        pokemon: ditto
+
+cookiejar: true
 
 GET /pokemon/$env._.pokemon: get-pokemon
 GET $get-pokemon.body.location_area_encounters: get-encounters
 
 POST https://httpbin.org/anything:
-  - alias: post-first-area
-    payload:
-      area: $get-encounters.body.0.location_area.name
+    - alias: post-first-area
+      payload:
+          area: $get-encounters.body.0.location_area.name
 
-  - alias: post-pokemon-type
-    payload:
-      type: $get-pokemon.body.types.0.type.name
+    - alias: post-pokemon-type
+      payload:
+          type: $get-pokemon.body.types.0.type.name
+
+    - alias: form-submission
+      form:
+          name: Dragapult
+
+    - alias: file-upload
+      formdata:
+          name: Beau
+          logo: $[createReadStream('../media/beau.png')]
+
+GET https://httpbin.org/status/418: teapot
+
+GET https://httpbin.org/cookies/set:
+    alias: set-cookies
+    params:
+        hello: World

package.json

@@ -1,10 +1,10 @@
 {
     "name": "beau",
-    "version": "0.11.1",
+    "version": "0.11.3",
     "description": "Testing APIs made easy.",
     "main": "./src/beau.js",
-    "author": "Sergio Diaz <seich@martianwabbit.com>",
-    "license": "MIT",
+    "author": "David Díaz <seich@martianwabbit.com>",
+    "license": "MIT + Commons Clause",
     "scripts": {
         "test": "jest -i",
         "test:coverage": "jest --coverage ./src",
@@ -17,19 +17,19 @@
     "dependencies": {
         "@oclif/command": "1.8.0",
         "@oclif/config": "1.17.0",
-        "@oclif/plugin-help": "3.2.0",
+        "@oclif/plugin-help": "3.2.1",
         "@oclif/plugin-warn-if-update-available": "1.7.0",
-        "ajv": "7.0.0-beta.6",
+        "ajv": "7.0.3",
         "beau-std": "0.9.4",
-        "better-ajv-errors": "0.6.7",
+        "better-ajv-errors": "0.7.0",
         "cli-color": "2.0.0",
         "clui": "0.3.6",
         "color-json": "2.0.1",
         "deepmerge": "4.2.2",
         "dotenv": "8.2.0",
-        "globby": "11.0.1",
+        "globby": "11.0.2",
         "is-plain-object": "5.0.0",
-        "js-yaml": "3.14.0",
+        "js-yaml": "4.0.0",
         "prompts": "2.4.0",
         "request": "2.88.2",
         "request-promise-native": "1.0.9",
@@ -40,7 +40,7 @@
         "jest": "26.6.3",
         "jest-watch-typeahead": "0.6.1",
         "strip-ansi": "6.0.0",
-        "np": "7.0.0"
+        "np": "7.2.0"
     },
     "oclif": {
         "commands": "./bin/cli/commands",

src/__tests__/beau.spec.js

@@ -11,7 +11,7 @@ describe(`Beau's config Loader.`, () => {
     it('should load the config', () => {
         moduleVersion.mockReturnValue(1)
 
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             version: 1
             endpoint: 'http://example.com'
 
@@ -27,7 +27,7 @@ describe(`Beau's config Loader.`, () => {
     it(`should load the request list using the configuration`, () => {
         moduleVersion.mockReturnValue(1)
 
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             version: 1
             endpoint: 'http://example.com'
 

src/__tests__/config.spec.js

@@ -6,7 +6,7 @@ requireg.resolving = false
 
 describe('Config', () => {
     it('should load valid config keys', () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             version: 1
             endpoint: http://martianwabbit.com
             shouldntBeAdded: true
@@ -19,7 +19,7 @@ describe('Config', () => {
     })
 
     it('should load requests', () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             endpoint: http://example.com
 
             GET /profile: get-profile
@@ -36,7 +36,7 @@ describe('Config', () => {
     })
 
     it('should set up defaults for all requests', () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             version: 1
             endpoint: 'http://example.com'
 
@@ -60,7 +60,7 @@ describe('Config', () => {
     })
 
     it('should load multiple hosts', () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
           version: 1
           endpoint: http://example.org
 
@@ -105,7 +105,7 @@ describe('Config', () => {
     })
 
     it('should namespace all aliases within an host', () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             hosts:
               - host: test1
                 endpoint: http://example.com
@@ -122,7 +122,7 @@ describe('Config', () => {
     })
 
     it(`should throw if host doesn't have a host key`, () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             hosts:
               - endpoint: http://example.com
                 GET /posts: posts
@@ -136,7 +136,7 @@ describe('Config', () => {
     })
 
     it(`should merge host settings with global settings`, () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
             defaults:
               headers:
                 hello: 1
@@ -159,7 +159,7 @@ describe('Config', () => {
     })
 
     it(`should allow different settings for the same request`, () => {
-        const doc = yaml.safeLoad(`
+        const doc = yaml.load(`
       host: https://example.com
       GET /1:
         - alias: req1

src/__tests__/shared.spec.js

@@ -5,7 +5,8 @@ const {
     UpperCaseKeys,
     removeOptionalKeys,
     toKebabCase,
-    replaceInObject
+    replaceInObject,
+    expandPath
 } = require('../shared')
 
 describe('Shared Utilities', () => {
@@ -72,4 +73,26 @@ describe('Shared Utilities', () => {
             expect(replaceInObject(a, (obj) => 'a')).toEqual({ b: 'a', c: 'a' })
         })
     })
+
+    describe('expandPath', () => {
+        test.each([
+            ['https://alchem.ee', 'api/v1/hello'],
+            ['https://alchem.ee/', '/api/v1/hello'],
+            ['https://alchem.ee', '/api/v1/hello'],
+            ['https://alchem.ee/', 'api/v1/hello']
+        ])(
+            'should add a base url to the path is the path is not a url: %s, %s',
+            (url, path) => {
+                expect(expandPath(url, path)).toEqual(
+                    'https://alchem.ee/api/v1/hello'
+                )
+            }
+        )
+
+        it('should return the path if its a fully fledged url on its own', () => {
+            expect(
+                expandPath('https://alchem.ee', 'https://martianwabbit.com')
+            ).toEqual('https://martianwabbit.com')
+        })
+    })
 })

src/shared.js

@@ -77,6 +77,14 @@ const isUrl = function (str) {
     }
 }
 
+const expandPath = (url, path) => {
+    if (isUrl(path)) {
+        return path
+    }
+
+    return url.replace(/\/+$/, '') + '/' + path.replace(/^\/+/, '')
+}
+
 module.exports = {
     requestRegex,
     replacementRegex,
@@ -86,5 +94,6 @@ module.exports = {
     toKebabCase,
     replaceInObject,
     moduleVersion,
-    isUrl
+    isUrl,
+    expandPath
 }