From 98cdddfb16f915d82486b9820e167d2f312b1274 Mon Sep 17 00:00:00 2001 From: Akihiro Komori Date: Tue, 11 Dec 2018 15:00:25 +0900 Subject: [PATCH 1/5] add BLE2902 --- src/Ble_esp32.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Ble_esp32.h b/src/Ble_esp32.h index 9db221f..4da3490 100644 --- a/src/Ble_esp32.h +++ b/src/Ble_esp32.h @@ -202,6 +202,9 @@ bool BleMidiInterface::begin(const char* deviceName) BLECharacteristic::PROPERTY_NOTIFY | BLECharacteristic::PROPERTY_WRITE_NR ); + // Add CCCD 0x2902 to allow notify + _characteristic->addDescriptor(new BLE2902()); + _characteristic->setCallbacks(new MyCharacteristicCallbacks(this)); // Start the service service->start(); From e18a6fd0051eabaa3b60f363d0e4de614d93397d Mon Sep 17 00:00:00 2001 From: alf45tar <35426671+alf45tar@users.noreply.github.com> Date: Mon, 31 Dec 2018 10:44:26 +0100 Subject: [PATCH 2/5] Update Ble_esp32.h --- src/Ble_esp32.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Ble_esp32.h b/src/Ble_esp32.h index 4da3490..313281d 100644 --- a/src/Ble_esp32.h +++ b/src/Ble_esp32.h @@ -4,6 +4,7 @@ #include #include #include +#include #include "utility/AbstractMidiInterface.h" using namespace Midi; From 876e6fd2bd4d8ffd9b2a4b3e715bd7e8f992e6c3 Mon Sep 17 00:00:00 2001 From: lathoub <4082369+lathoub@users.noreply.github.com> Date: Mon, 31 Dec 2018 11:20:33 +0100 Subject: [PATCH 3/5] Update README.md added inspiration by Pedalino --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index ff4992e..efbb1a9 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,7 @@ MIDI over Bluetooth Low Energy (BLE-MIDI) 1.0 for Arduino Call interface similar to [FortySevenEffects/MIDI](https://github.com/FortySevenEffects/arduino_midi_library) and [lathoub/AppleMIDI](https://github.com/lathoub/Arduino-AppleMIDI-Library) +Inspired by Pedalino https://github.com/alf45tar/Pedalino by alf45tar # Supported devices ESP32 From 810429cdd2b39df7a54ecc22439117309ab30e34 Mon Sep 17 00:00:00 2001 From: lathoub <4082369+lathoub@users.noreply.github.com> Date: Mon, 31 Dec 2018 11:20:45 +0100 Subject: [PATCH 4/5] Update README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index efbb1a9..ecc62c4 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,7 @@ MIDI over Bluetooth Low Energy (BLE-MIDI) 1.0 for Arduino Call interface similar to [FortySevenEffects/MIDI](https://github.com/FortySevenEffects/arduino_midi_library) and [lathoub/AppleMIDI](https://github.com/lathoub/Arduino-AppleMIDI-Library) + Inspired by Pedalino https://github.com/alf45tar/Pedalino by alf45tar # Supported devices From 79c7d4ec22f0a1ea37c609d5304e585cc89a565b Mon Sep 17 00:00:00 2001 From: Da CodeKid Date: Mon, 18 Feb 2019 14:35:25 -0500 Subject: [PATCH 5/5] Fix sendChannelMessage Signature on SendNoteOn/Off Fix sendChannelMessage call Signature on SendNoteOn & SendNoteOff functions --- src/utility/AbstractMidiInterface.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utility/AbstractMidiInterface.h b/src/utility/AbstractMidiInterface.h index 26a0071..3b41bf7 100644 --- a/src/utility/AbstractMidiInterface.h +++ b/src/utility/AbstractMidiInterface.h @@ -277,11 +277,11 @@ namespace Midi { public: // sending void sendNoteOn(DataByte note, DataByte velocity, Channel channel) { - sendChannelMessage(MidiType::NoteOn, channel, note, velocity); + sendChannelMessage(MidiType::NoteOn, note, velocity, channel); } void sendNoteOff(DataByte note, DataByte velocity, Channel channel) { - sendChannelMessage(MidiType::NoteOff, channel, note, velocity); + sendChannelMessage(MidiType::NoteOff, note, velocity, channel); } void sendProgramChange(DataByte number, Channel channel) {